Skip to content

Conversation

@qixiang-99
Copy link
Collaborator

@qixiang-99 qixiang-99 commented Jun 7, 2025

[DON'T MERGE] [feat] Add VSWA support for PyTorch KVCacheManager

This PR depends on PR4667, and the code may change since PR4667 is not yet merged.

Pending tasks:

  • Clean up logging code
  • Add detailed description
  • Update code after merging PR4667

Description

Please explain the issue and the solution in short.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@qixiang-99 qixiang-99 changed the title VSWA support for PyTorch KVCacheManager [DON'T MERGE] [feat]VSWA support for PyTorch KVCacheManager Jun 7, 2025
@qixiang-99
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7961 [ run ] triggered by Bot

@qixiang-99 qixiang-99 marked this pull request as ready for review June 7, 2025 07:25
@qixiang-99 qixiang-99 requested review from a team as code owners June 7, 2025 07:25
@qixiang-99 qixiang-99 requested review from byshiue and lfr-0531 and removed request for byshiue and lfr-0531 June 7, 2025 07:25
@qixiang-99 qixiang-99 marked this pull request as draft June 7, 2025 07:27
@tensorrt-cicd
Copy link
Collaborator

PR_Github #7961 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #5763 completed with status: 'FAILURE'

@qixiang-99
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7994 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7994 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5793 completed with status: 'FAILURE'

@qixiang-99 qixiang-99 force-pushed the qixiang-feat-on-netanel-0606 branch from 0d98b3c to 41a971a Compare June 8, 2025 22:35
@qixiang-99
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8046 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8046 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5832 completed with status: 'FAILURE'

@qixiang-99 qixiang-99 force-pushed the qixiang-feat-on-netanel-0606 branch from 41a971a to 9620924 Compare June 9, 2025 17:34
@qixiang-99
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8149 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8149 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5906 completed with status: 'FAILURE'

…out whether there are more issues.

Signed-off-by: qixiang-99 <[email protected]>
- Many tests directly pass executor.KvCacheConfig to KvCacheManager, apply a conversion if this happen
- add `self.blocks_in_primary_pool` and `self.blocks_in_secondary_pool` as these are used for standard case.

Signed-off-by: qixiang-99 <[email protected]>
…ype (the mirror class of executor.kvcache_config)

Signed-off-by: qixiang-99 <[email protected]>
@qixiang-99 qixiang-99 force-pushed the qixiang-feat-on-netanel-0606 branch from 9620924 to 153360c Compare June 10, 2025 07:46
@qixiang-99
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8240 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8240 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5972 completed with status: 'FAILURE'

@qixiang-99 qixiang-99 closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants